Ona custom changes #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
force-pushed
the
ona-custom-changes
branch
2 times, most recently
from
2187ba4 to
b740c9d
Compare
FrankApiyo
force-pushed
the
ona-custom-changes
branch
3 times, most recently
from
2bb13a6 to
0325aff
Compare
FrankApiyo
force-pushed
the
ona-custom-changes
branch
from
0325aff to
9ac5039
Compare
bonfaceshisakha
force-pushed
the
ona-custom-changes
branch
from
2f57741 to
db113da
Compare
ciremusyoka
reviewed
Dec 20, 2022
index.js
Outdated
| } | ||
| }) | ||
| .catch((error) => { | ||
| console.log(error) |
ciremusyoka
reviewed
Dec 20, 2022
index.js
Outdated
| } else if ("/health-check" == req.url) { | ||
| done() | ||
| } else { | ||
| done("Authentication Failure"); |
There was a problem hiding this comment.
Can we also add a status code (401)
There was a problem hiding this comment.
I couldn't find how to do this from fastify documentation
ciremusyoka
reviewed
Dec 20, 2022
index.js
Outdated
| .then(fastify => // LAUNCH SERVER | ||
| fastify.listen({ port: process.env.SERVER_PORT || 3000, host: process.env.SERVER_HOST || '0.0.0.0' }, (err, address) => { | ||
| if (err) { | ||
| console.log(err) |
ciremusyoka
reviewed
Dec 20, 2022
| } | ||
| console.info(`Server listening on ${address}`) | ||
| })) | ||
| .catch(console.log) |
There was a problem hiding this comment.
Could we maybe add the error to logs
There was a problem hiding this comment.
If t this error occurs, most likely we didn't import fastify successfully and so the logger has not been initialized
FrankApiyo
force-pushed
the
ona-custom-changes
branch
from
cef99bc to
8bd36bb
Compare
April updates 2024
Optimive mvt query
Use node:20.13.1-alpine3.19
Signed-off-by: Kipchirchir Sigei <[email protected]>
Signed-off-by: Kipchirchir Sigei <[email protected]>
Update base image to node:20.15.0-alpine3.19
Update base image to node:20.15.1-alpine3.20
Get map bounds
Update axios to v1.7.5
Remove express and upgrade node version
Update find-my-way 8.0.0 -> 8.2.2
Oct 30 2024 sec updates
Update cross-spawn
Update package-lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.